Repository navigation
Fix greenlet re-entry wakeups and closed transport protocol leaks - #117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A greenlet resumed during a later loop run can temporarily replace the C stack containing the active ready queue. Allocate that queue on the heap so call_soon always writes to stable storage. This restores lock wakeups and task cancellation when startup and serving enter the loop at different C stack depths.
After connection_lost, stream transports now release their protocol, cached bound methods, fast-reader references and saved context. Subprocess transports release their protocol/context too. Cleanup runs even when the callback raises, and Python references are dropped outside state locks so finalizers can reenter safely. Stream get_protocol() returns None after teardown; socket extra-info behavior is preserved.
Add 21 regression cases: six stack depths with the minimal and SQLAlchemy greenlet bridges; connection churn with close, abort and peer disconnect, including callback failures; StreamReaderProtocol fast-path ownership; and subprocess protocol ownership. Document the scope and reproduction commands.
Validation on Linux / CPython 3.14.7:
End-to-end Granian/PostgreSQL load and shutdown behavior was not tested locally; CI supplies the OS/Python and PostgreSQL coverage.
Fixes #115
Fixes #116